chore: update seeds for v21 release #6151

knst · 2024-07-24T17:54:41Z

Issue being fixed or feature implemented

What was done?

Extra onion seeds are provided by pasta.

dash-cli protx list valid 1 2110129 > protx_list.json

# Make sure the onion seeds still work!
while IFS= read -r line
do
  address=$(echo $line | cut -d':' -f1)
  port=$(echo $line | cut -d':' -f2)
  nc -v -x 127.0.0.1:9050 -z $address $port
done < "onion_seeds.txt"

python3 makeseeds.py protx_list.json onion_seeds.txt > nodes_main.txt
python3 generate-seeds.py . > ../../src/chainparamsseeds.h

How Has This Been Tested?

n/a

Breaking Changes

n/a

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone

PastaPastaPasta · 2024-07-24T18:07:17Z

contrib/seeds/README.md

-```bash
-dash-cli protx list valid 1 2018966 > protx_list.json
+```sh
+dash-cli protx list valid 1 > protx_list.json


you should be specifying specific block here?

nope, by default it's "current tip"

Yeah... Arguably we should be specifying a specific hash though so it's more reproducible

Suggested change

dash-cli protx list valid 1 > protx_list.json

dash-cli protx list valid 1 _TIP_ > protx_list.json

?

You have to pick a specific block to make it reproducible. Could change that rpc to accept block hashes but specifying block height is good enough if that block is chainlocked already.

Idk, it's probably fine. We've had trouble actually reproducing these before

why make it worse though? :)

True :) I defer to @UdjinM6 :)

PastaPastaPasta

utACK 133fc20

see udjin comment

UdjinM6

Should revert changes in contrib/seeds/README.md imo, they are both irrelevant and incorrect

PastaPastaPasta · 2024-07-24T18:20:50Z

Sooo what was the height you used? :)

knst · 2024-07-24T18:22:25Z

dash-cli protx list valid 1 2110129 > protx_list.json

PastaPastaPasta · 2024-07-24T18:29:11Z

Unable to reproduce, I believe due to local issue:

'Resolver' object has no attribute 'resolve'

UdjinM6 · 2024-07-24T18:33:26Z

contrib/seeds/README.md

 The seeds compiled into the release are created from the current protx list, like this:

-```bash
-dash-cli protx list valid 1 2018966 > protx_list.json
+```sh
+dash-cli protx list valid 1 _TIP_ > protx_list.json


The note above is not accurate too actually, it must be a list from a "safe" block, not a "current" one. I'd still prefer to revert these changes and fix it in a separate PR.

I doesn't like hard-coded 2018966 because it's easy to copy-paste and use same 2018966 for next time.

I agree but this PR is a wrong place to fix it

UdjinM6 · 2024-07-24T18:36:48Z

I'm getting lots of ERR: Could not resolve ASN... so yeah, it's not reproducible for me too 😞

knst · 2024-07-24T18:41:30Z

I'm getting lots of ERR: Could not resolve ASN... so yeah, it's not reproducible for me too 😞

I got 698 failures:

$ cat | grep 'Could not resolve' -c
698

```sh dash-cli protx list valid 1 2110129 > protx_list.json while IFS= read -r line do address=$(echo $line | cut -d':' -f1) port=$(echo $line | cut -d':' -f2) nc -v -x 127.0.0.1:9050 -z $address $port done < "onion_seeds.txt" python3 makeseeds.py protx_list.json onion_seeds.txt > nodes_main.txt python3 generate-seeds.py . > ../../src/chainparamsseeds.h ```

UdjinM6

utACK 43c3953

PastaPastaPasta

utACK 43c3953

43c3953 chore: update seeds (Konstantin Akimov) 16dd043 chore: added extra onion seeds (provided by pasta) (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented dashpay#6081 ## What was done? Extra onion seeds are provided by pasta. ```sh dash-cli protx list valid 1 2110129 > protx_list.json # Make sure the onion seeds still work! while IFS= read -r line do address=$(echo $line | cut -d':' -f1) port=$(echo $line | cut -d':' -f2) nc -v -x 127.0.0.1:9050 -z $address $port done < "onion_seeds.txt" python3 makeseeds.py protx_list.json onion_seeds.txt > nodes_main.txt python3 generate-seeds.py . > ../../src/chainparamsseeds.h ``` ## How Has This Been Tested? n/a ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK 43c3953 PastaPastaPasta: utACK dashpay@43c3953 Tree-SHA512: 8583f030949c6b26b5410eaa4db4f9b85fbe14bc147083861519d9564ae1fff52716b2d8deb233d30ecfb679e778cb2bb2f0ef3dee392cff1986b004b03d9e1e

cd0a3a6 Merge #6154: chore: remove trailing whitespaces in release notes (pasta) 6bc60a7 Merge #6151: chore: update seeds for v21 release (pasta) 88e949a Merge #6146: chore: bump assumevalid, minchainwork, checkpoints, chaintxdata (pasta) cc14427 Merge #6144: docs: release notes for v21.0.0 (pasta) 0a8ece1 Merge #6122: chore: translations 2024-07 (pasta) 146d244 Merge #6140: feat: harden all sporks on mainnet to current values (pasta) 024d272 Merge #6126: feat: enable EHF activation of MN_RR on mainnet (pasta) e780b3d Merge #6125: docs: update manpages for 21.0 (pasta) 5ede23c Merge #6118: docs: add release notes notifying change of default branch to `develop` (pasta) 1b6fe9c Merge #6117: docs: update supported versions in SECURITY.md (pasta) 27d20be Merge #6116: fix: mitigate crashes associated with some upgradetohd edge cases (pasta) Pull request description: ## Issue being fixed or feature implemented Backports to v21 for rc.3; there are more PRs to be back ported here ## What was done? see commits ## How Has This Been Tested? ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK cd0a3a6 Tree-SHA512: 0a8d027c5952fcb61317cc413a0de1f3152ae675c5690942400c3e4655cc6a803c702a7e1b18d8dac77aa0f483783f5cdbe29d6c0592165c4f0517d6f37b91a4

98a3393 chore: set release to true (pasta) cd0a3a6 Merge #6154: chore: remove trailing whitespaces in release notes (pasta) 6bc60a7 Merge #6151: chore: update seeds for v21 release (pasta) 88e949a Merge #6146: chore: bump assumevalid, minchainwork, checkpoints, chaintxdata (pasta) cc14427 Merge #6144: docs: release notes for v21.0.0 (pasta) 0a8ece1 Merge #6122: chore: translations 2024-07 (pasta) 146d244 Merge #6140: feat: harden all sporks on mainnet to current values (pasta) 024d272 Merge #6126: feat: enable EHF activation of MN_RR on mainnet (pasta) e780b3d Merge #6125: docs: update manpages for 21.0 (pasta) 5ede23c Merge #6118: docs: add release notes notifying change of default branch to `develop` (pasta) 1b6fe9c Merge #6117: docs: update supported versions in SECURITY.md (pasta) 27d20be Merge #6116: fix: mitigate crashes associated with some upgradetohd edge cases (pasta) db82817 Merge #6106: feat: create new composite quorum-command platformsign (pasta) a45e6df Merge #6104: fix: adjust incorrect parameter description that says there is a default that doesn't exist (pasta) 7330982 Merge #6100: feat: make whitelist works with composite commands for platform needs (pasta) 9998ffd Merge #6096: feat: split type of error in submitchainlock - return enum in CL verifying code (pasta) cdf7a25 Merge #6095: fix: createwallet to require 'load_on_startup' for descriptor wallets (pasta) c1c2c55 Merge #6092: fix: mixing for partially unlocked descriptor wallets (pasta) 1175486 Merge #6073: feat: add logging for RPC HTTP requests: command, user, http-code, time of running (pasta) Pull request description: ## Issue being fixed or feature implemented Suppressed changes from be83865 so the diff is empty. ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: ACK 158cf86; no diff knst: ACK 158cf86 Tree-SHA512: 3310a39fbcb45bdf09f885fe77ba769c0a715869a3bb287eaf0f2cf54b35a7e1f832c88df3bd31097eabf2d375515c1b87ff05e0c3282cef642833a154c42bbe

knst added the backport-candidate-21.0.x label Jul 24, 2024

knst added this to the 21 milestone Jul 24, 2024

knst requested review from UdjinM6 and PastaPastaPasta July 24, 2024 17:54

PastaPastaPasta reviewed Jul 24, 2024

View reviewed changes

PastaPastaPasta previously approved these changes Jul 24, 2024

View reviewed changes

UdjinM6 requested changes Jul 24, 2024

View reviewed changes

knst requested review from UdjinM6 and PastaPastaPasta July 24, 2024 18:20

UdjinM6 reviewed Jul 24, 2024

View reviewed changes

knst added 2 commits July 25, 2024 01:57

chore: added extra onion seeds (provided by pasta)

16dd043

knst force-pushed the v21-update-seeds branch from bbaab8e to 43c3953 Compare July 24, 2024 19:00

UdjinM6 approved these changes Jul 24, 2024

View reviewed changes

PastaPastaPasta approved these changes Jul 24, 2024

View reviewed changes

PastaPastaPasta merged commit f81000b into dashpay:develop Jul 24, 2024
7 of 8 checks passed

knst deleted the v21-update-seeds branch July 24, 2024 19:23

UdjinM6 removed the backport-candidate-21.0.x label Jul 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update seeds for v21 release #6151

chore: update seeds for v21 release #6151

knst commented Jul 24, 2024 •

edited

Loading

PastaPastaPasta Jul 24, 2024

knst Jul 24, 2024

PastaPastaPasta Jul 24, 2024

knst Jul 24, 2024

UdjinM6 Jul 24, 2024 •

edited

Loading

PastaPastaPasta Jul 24, 2024

UdjinM6 Jul 24, 2024

PastaPastaPasta Jul 24, 2024

PastaPastaPasta left a comment

UdjinM6 left a comment

PastaPastaPasta commented Jul 24, 2024

knst commented Jul 24, 2024

PastaPastaPasta commented Jul 24, 2024

UdjinM6 Jul 24, 2024

knst Jul 24, 2024

UdjinM6 Jul 24, 2024

UdjinM6 commented Jul 24, 2024

knst commented Jul 24, 2024 •

edited

Loading

UdjinM6 left a comment

PastaPastaPasta left a comment

	dash-cli protx list valid 1 > protx_list.json
	dash-cli protx list valid 1 _TIP_ > protx_list.json

chore: update seeds for v21 release #6151

chore: update seeds for v21 release #6151

Conversation

knst commented Jul 24, 2024 • edited Loading

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UdjinM6 Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PastaPastaPasta left a comment

Choose a reason for hiding this comment

UdjinM6 left a comment

Choose a reason for hiding this comment

PastaPastaPasta commented Jul 24, 2024

knst commented Jul 24, 2024

PastaPastaPasta commented Jul 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UdjinM6 commented Jul 24, 2024

knst commented Jul 24, 2024 • edited Loading

UdjinM6 left a comment

Choose a reason for hiding this comment

PastaPastaPasta left a comment

Choose a reason for hiding this comment

knst commented Jul 24, 2024 •

edited

Loading

UdjinM6 Jul 24, 2024 •

edited

Loading

knst commented Jul 24, 2024 •

edited

Loading