Improve CreateDenominated and MakeCollateralAmounts #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice, utACK |
|
Added few more improvements:
|
|
Needs a rebase :) |
- should use funds only from the same receiving address - should denominate while has funds but has not enough denoms - slightly refactored
…nts: - return change to the origin address to use it in future splits - fix a bug with incorrect overshoot - more debug (optional/errors only) and fixed var names
|
rebased :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users might manage their receiving addresses carefully trying to avoid any links. The best way to do this is to use different wallets otherwise user might accidentally link them together when he sends funds without using CoinControl. Moreover currently it's not secure (privacy wise) to have all funds in one wallet and mix them because it's basically the same as sending without CoinControl. This PR should solve the problem by allowing wallet to create denoms and mixing collaterals only from funds within the same receiving address. This imo also eliminates the need to split creation of denoms in time so we can create all of them ahead of time now (step by step though). As for common users who don't care that much of linking previous unmixed funds - they will get privacy improvement "for free" imo, creating denoms this way should not negatively affect mixing time on average.
Changes: