Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: reorganize HD wallet section #297

Merged
merged 2 commits into from
Sep 7, 2023
Merged

docs: reorganize HD wallet section #297

merged 2 commits into from
Sep 7, 2023

Conversation

rmdash
Copy link
Contributor

@rmdash rmdash commented Sep 4, 2023 •
edited by github-actions bot
Loading

thephez
thephez requested changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order looks okay, but the labels need to be moved to be before the relevant sections so links don't go to the wrong sections

docs/user/wallets/dashcore/advanced.rst Outdated Show resolved Hide resolved
docs/user/wallets/dashcore/advanced.rst Outdated Show resolved Hide resolved
docs/user/wallets/dashcore/advanced.rst Outdated Show resolved Hide resolved
docs/user/wallets/dashcore/advanced.rst Outdated Show resolved Hide resolved
thephez
thephez approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thephez thephez changed the title Update advanced.rst docs: reorganize HD wallet section Sep 7, 2023
@thephez thephez merged commit c3e2f46 into dashpay:19.0.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thephez thephez thephez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmdash @thephez