Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Use changes from DataFusion's push_down_filter #945

Closed
wants to merge 7 commits into from

Conversation

sarahyurick
Copy link
Collaborator

Opening this to make it easier for others to build with the changes from apache/datafusion#4365

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #945 (096a8bc) into main (cf719c5) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   75.91%   76.04%   +0.12%     
==========================================
  Files          73       73              
  Lines        4082     4082              
  Branches      739      739              
==========================================
+ Hits         3099     3104       +5     
+ Misses        823      814       -9     
- Partials      160      164       +4     
Impacted Files Coverage Δ
dask_sql/_version.py 35.31% <0.00%> (+1.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarahyurick
Copy link
Collaborator Author

sarahyurick commented Nov 30, 2022

TODO:

@sarahyurick sarahyurick marked this pull request as draft November 30, 2022 08:05
@sarahyurick
Copy link
Collaborator Author

Closing since push_down_filter can now be tested with #949 instead.

@sarahyurick sarahyurick closed this Dec 5, 2022
@sarahyurick sarahyurick deleted the push_down_filter branch May 26, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants