Add failing test for make_pod_from_dict #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes failures in the deserialize method that we saw when deploying pangeo.pydata.org
yuvipanda
reviewed
Feb 2, 2018
| ], | ||
| "image": "image-name", | ||
| "name": "dask-worker", | ||
| "security_context": {"capabilities": {"add": ["SYS_ADMIN"]}, |
There was a problem hiding this comment.
This needs to be securityContext, since we're asking for dicts to be in the same format as what Kubernetes expects (those are in camelCase, not _ case).
There was a problem hiding this comment.
I'm going to spend time fixing and documenting this properly.
|
Ah ha, that would explain things. Thanks!
…On Fri, Feb 2, 2018 at 5:42 PM, Yuvi Panda ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In daskernetes/tests/test_objects.py
<#30 (comment)>:
> + "app": "dask",
+ "component": "dask-worker"
+ }
+ },
+ "spec": {
+ "containers": [
+ {
+ "args": [
+ "dask-worker",
+ "$(DASK_SCHEDULER_ADDRESS)",
+ "--nthreads",
+ "1"
+ ],
+ "image": "image-name",
+ "name": "dask-worker",
+ "security_context": {"capabilities": {"add": ["SYS_ADMIN"]},
I'm going to spend time fixing and documenting this properly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszKmzF9FevrXrvRQM26UipOuPL2U8ks5tQ49WgaJpZM4R31pm>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes failures in the deserialize method that we saw when
deploying pangeo.pydata.org