Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handles out-of-range nodeport ranges #705

Closed
wants to merge 10 commits into from
Closed

Handles out-of-range nodeport ranges #705

wants to merge 10 commits into from

Commits on Apr 26, 2023

  1. create new pr, initial changes

    @skirui-source
    skirui-source committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    e4c22c1 View commit details
    Browse the repository at this point in the history

  2. switch tests order

    @skirui-source
    skirui-source committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    ab5d686 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. add checks for both and

    @skirui-source
    skirui-source committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    91238d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. check if field are dict types

    @skirui-source
    skirui-source committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d2568a6 View commit details
    Browse the repository at this point in the history

  2. edit the loop that checks dictionary fields

    @skirui-source
    skirui-source committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    1a1cdd9 View commit details
    Browse the repository at this point in the history

  3. fix failing tests

    @skirui-source
    skirui-source committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    5a2d7a7 View commit details
    Browse the repository at this point in the history

  4. create new pr

    @skirui-source
    skirui-source committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    1ec75fc View commit details
    Browse the repository at this point in the history

  5. explicitly set error messaege from exception

    @skirui-source
    skirui-source committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    046d6ec View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. add validation for input node ports

    @skirui-source
    skirui-source committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d5507cc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:skirui-source/dask-kubernetes into … 

    …nodeport_fix
    @skirui-source
    skirui-source committed May 2, 2023
    Configuration menu
    Copy the full SHA
    719bf5b View commit details
    Browse the repository at this point in the history