Use kr8s in networking functions #764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
commented
Jul 13, 2023
| async def port_forward_service(service, remote_port, local_port=None): | ||
| async with PortForward(service, remote_port, local_port) as port: | ||
| print(f"Forwarding to port {port}") | ||
| return port |
There was a problem hiding this comment.
This should be port.local_port
Comment on lines
93
to
95
| async with PortForward(service, remote_port, local_port) as port: | ||
| print(f"Forwarding to port {port}") | ||
| return port |
There was a problem hiding this comment.
If you do async with the port forward will close when the function returns.
Suggested change
| async with PortForward(service, remote_port, local_port) as port: | |
| print(f"Forwarding to port {port}") | |
| return port | |
| pf = service.portforward(remote_port, local_port) | |
| port = await pf.start() | |
| print(f"Forwarding to port {port}") | |
| return port |
We might also want to return pf and hold a reference to it somewhere but I'm not sure.
|
This was superseded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperate operator networking functions and use kr8s api in them.