Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nil with null in helm chart #766

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

bstadlbauer
Copy link
Collaborator

We've just tried to deploy the 2022.7.0 version of the helm chart and ran into:

Handler 'daskworkergroup_replica_update/spec.worker.replicas' failed with an exception. Will retry.
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/kopf/_core/actions/execution.py", line 276, in execute_handler_once
    result = await invoke_handler(
  File "/usr/local/lib/python3.10/site-packages/kopf/_core/actions/execution.py", line 371, in invoke_handler
    result = await invocation.invoke(
  File "/usr/local/lib/python3.10/site-packages/kopf/_core/actions/invocation.py", line 116, in invoke
    result = await fn(**kwargs)  # type: ignore
  File "/usr/local/lib/python3.10/site-packages/dask_kubernetes/operator/controller/controller.py", line 639, in daskworkergroup_replica_update
    batch_size = min(workers_needed, SIZE) if SIZE else workers_needed
TypeError: '<' not supported between instances of 'str' and 'int'

We're currently testing whether settings things to null fixes this. cc @dyu-bot

@bstadlbauer bstadlbauer changed the title Replace nil with null in helm chart Replace nil with null in helm chart Jul 13, 2023
@jacobtomlinson jacobtomlinson merged commit 649ada5 into dask:main Jul 13, 2023
7 of 8 checks passed
@jacobtomlinson
Copy link
Member

Thanks @bstadlbauer. I've just tagged 2023.7.1 with this fix in.

@dyu-bot
Copy link
Contributor

dyu-bot commented Jul 13, 2023

Thanks for the quick release @jacobtomlinson

@dyu-bot
Copy link
Contributor

dyu-bot commented Jul 13, 2023

Actually @jacobtomlinson it's still failing to create workers with the new release.

I believe because here the env variable must be a string. So need to cast these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants