Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke test for helm deployment #768

Closed
wants to merge 6 commits into from

Conversation

bstadlbauer
Copy link
Collaborator

This PR adds a smoke test that installs the helm chart into the local kind cluster to check whether the deployment is working correctly and a simple cluster can come up. This should minimize releasing broken versions.

@bstadlbauer
Copy link
Collaborator Author

@jacobtomlinson Seems like the test setup is slow and I would expect this to be due to the docker build that's happening.

Should I try to improve the build time there by leveraging caching?

@bstadlbauer
Copy link
Collaborator Author

bstadlbauer commented Jul 14, 2023

I've also added a second tests with --set=rbac.create=false which seems to be failing - is this expected? (we're not using this internally, but that's what was used in the original issue #749)

@jacobtomlinson
Copy link
Member

Seems like the test setup is slow and I would expect this to be due to the docker build that's happening.

I'm curious why the existing docker image fixture isn't being used here?

I've also added a second tests with --set=rbac.create=false which seems to be failing - is this expected?

We should look into this. Do you want to xfail the test for now and open an issue to track it?

@bstadlbauer
Copy link
Collaborator Author

Closing this as I've had not had time to get back to this

@bstadlbauer bstadlbauer closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants