Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__dask_distributed_pack__(): client argument #4248

Merged
merged 5 commits into from
Nov 18, 2020

Conversation

madsbk
Copy link
Contributor

@madsbk madsbk commented Nov 17, 2020

This PR implements the new client argument of Layer.__dask_distributed_pack__() introduced by dask/dask#6850

@jrbourbeau
Copy link
Member

Hmm we're getting a msgpack error when running distributed/tests/test_client.py::test_profile_server (see https://github.com/dask/distributed/runs/1414687711#step:8:117):

   File "msgpack/_packer.pyx", line 286, in msgpack._cmsgpack.Packer.pack
  File "msgpack/_packer.pyx", line 292, in msgpack._cmsgpack.Packer.pack
  File "msgpack/_packer.pyx", line 289, in msgpack._cmsgpack.Packer.pack
  File "msgpack/_packer.pyx", line 225, in msgpack._cmsgpack.Packer._pack
  File "msgpack/_packer.pyx", line 225, in msgpack._cmsgpack.Packer._pack
  File "msgpack/_packer.pyx", line 225, in msgpack._cmsgpack.Packer._pack
  [Previous line repeated 508 more times]
  File "msgpack/_packer.pyx", line 223, in msgpack._cmsgpack.Packer._pack
  File "msgpack/_packer.pyx", line 157, in msgpack._cmsgpack.Packer._pack
ValueError: recursion limit exceeded.

Though this seems unrelated to the changes in this PR. I've pushed an empty commit to trigger CI and see if the failure persists. I don't recall seeing it before.

@jrbourbeau
Copy link
Member

Alright, it looks like the test_profile_server failure is unrelated to the changes in this PR. It doesn't consistently fail on CI and I've not been able to reproduce it locally. I opened up #4251 in case this failure pops up on other PRs.

@jrbourbeau jrbourbeau merged commit eda9bcc into dask:master Nov 18, 2020
@madsbk madsbk deleted the dask_distributed_pack_client_arg branch November 18, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants