Drop support for Python 3.6 #4390
Conversation
.travis.yml
Outdated
| @@ -6,8 +6,7 @@ dist: trusty | |||
|
|
|||
| env: | |||
| matrix: | |||
| - PYTHON=3.6 TESTS=true COVERAGE=true PACKAGES="lz4" TORNADO=5 CRICK=true | |||
| - PYTHON=3.7 TESTS=true PACKAGES="python-snappy python-blosc" TORNADO=6 | |||
| - PYTHON=3.7 TESTS=true COVERAGE=true PACKAGES="lz4 python-snappy python-blosc" CRICK=true TORNADO=5 | |||
There was a problem hiding this comment.
I think here you removed the test case for when snappy and blosc are not installed
There was a problem hiding this comment.
I think the new Python 3.7 environment file is not including snappy or blosc, but please recheck and make sure this looks ok 🙂
|
Thanks for reviewing @crusaderky, I'll update accordingly |
|
Perhaps it would be best to restart this PR from scratch? |
|
There's a Python 3.9 PR ( #4460 ). Maybe we can just drop Python 3.6 in that? Or shortly thereafter? |
the plan is to drop 3.6 immediately after the 3.9 PR is merged. I'll take care of both |
|
Would it makes sense to do this after the upcoming release? Sorry if this was already answered elsewhere |
|
xref-ing dask/dask#7006 (comment) from over in the corresponding PR in Dask. For Distributed dropping Python 3.6 in the next release has the (potential) benefit of resolving #4538 (assuming it's only a rare Python 3.6 effect -- though this hasn't been completely confirmed) |
|
Cool. Let's keep the discussion there. Then we can handle both PRs based on that outcome 🙂 |
|
Looks like we have a conflict here. Would you be able to look at that James? 🙂 |
|
Oops that didn’t work as expected. Well if people here can take another look that would be appreciated 🙂 |
|
In metrics.py, you should drop |
|
Thanks all for reviewing! |
|
Thanks for working on this James! 😄 |
For additional context see the discussion over in dask/community#66. There's a corresponding PR for dropping Python 3.6 in Dask at dask/dask#7006.