Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix Cythonized Scheduler test failures #4767

Closed
wants to merge 2 commits into from

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Apr 29, 2021

Reverts the tests skipped/xfailed in PR ( #4764 ) due to issues encountered with the Cythonized Scheduler. Doing this to fix those tests and get them passing in the Cythonized Scheduler case as well.

Note: This PR mainly exists for tracking purposes while we sort out the different tests failures.

  • Closes #xxxx
  • Tests added / passed
  • Passes black distributed / flake8 distributed / isort distributed

@jakirkham
Copy link
Member Author

Was able to fix a couple of these without too much difficulty. Broke out in PR ( #4768 ).

@jakirkham jakirkham mentioned this pull request Apr 29, 2021
@jakirkham
Copy link
Member Author

One avenue to addressing these remaining issues would be to continue with splitting apart Scheduler & SchedulerState with Martin's PR ( #5176 ), which opens the door to moving SchedulerState into its own module. If SchedulerState could live in its own module that gets Cythonized without the Scheduler, there would be less need to worry about how Cython handles some of these other test failures that cropped up with the Scheduler.

@jakirkham jakirkham mentioned this pull request Apr 12, 2022
3 tasks
@jakirkham jakirkham closed this Apr 29, 2022
@jakirkham jakirkham deleted the fix_cy_tst_xfails branch April 29, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant