WIP Subscribe events - PubSub Extension #5218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
commented
Aug 16, 2021
| name = [name] | ||
| for n in name: | ||
| self.events[n] # init defaultdict | ||
| self.extensions["pubsub"].handle_message(name=n, msg=msg) |
There was a problem hiding this comment.
This is currently ugly but the handle_message of the extension will append the event to the deque and inc the counter now
Comment on lines
+356
to
+357
| # FIXME If I use to_serialize here, this breaks msgs of type dict! | ||
| data = {"op": "pubsub-msg", "name": self.name, "msg": msg} |
There was a problem hiding this comment.
This broke for simple dict type messages by raising a keyerror on on the remote side. probably a bug but how to deal with the serialized objects in general would be one of my questions
Comment on lines
+3626
to
+3653
| if topic not in self.event_subscriptions: | ||
| sub = self.event_subscriptions[topic] = Sub(topic, client=self) | ||
| else: | ||
| sub = self.event_subscriptions[topic] | ||
|
|
||
| if topic in self.event_handlers: | ||
| fut = self.event_handlers[topic] | ||
| fut.cancel() | ||
|
|
||
| self.event_handlers[topic] = fut = asyncio.ensure_future( | ||
| self._handle_events(sub=sub, handler=handler) | ||
| ) | ||
|
|
||
| def unsubscribe_topic(self, topic): | ||
| """Unsubscribe from a topic and remove event handler | ||
|
|
||
| See Also | ||
| -------- | ||
| dask.distributed.Client.subscribe_topic | ||
| dask.distributed.Client.get_events | ||
| dask.distributed.Client.log_event | ||
| """ | ||
| if topic in self.event_handlers: | ||
| fut = self.event_handlers.pop(topic) | ||
| fut.cancel() | ||
| sub = self.event_subscriptions.pop(topic) | ||
| sub.stop() | ||
| else: |
There was a problem hiding this comment.
This is mostly convenience stuff to execute an event handler on client side. The actual subscription is handled via the extension
Closed
|
closing in favour of #5217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation to #5217 using the pubsub extensions
see also #5184
The scheduler is treated as a special case for subscribing via the toggle
log_queuewhen registering a publisher. This toggle signals that the events shall be logged in the internalScheduler.eventslog as well.I am reusing the same mechanism as for client subscribers. As soon as a client subscribes to an event, the publisher is forced to loop in the scheduler and the scheduler communicates with the client.
Internal log_events take a shortcut which is currently a bit ugly. Didn't want to overcommit to this before we're sure this is a valid approach