Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use asyncio for TCP/TLS comms #5450

Merged
merged 16 commits into from
Dec 10, 2021
Merged

Use asyncio for TCP/TLS comms #5450

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a919a07
WIP: Use asyncio for TCP/TLS comms
jcrist Oct 18, 2021
504e92a
Fixups
jcrist Oct 22, 2021
61bdddf
Fixup tests
jcrist Nov 1, 2021
67c7a73
More fixups
jcrist Nov 2, 2021
5a94477
Backwards compat, add envvar
jcrist Nov 4, 2021
ed81516
Optimize send for larger messages
jcrist Nov 4, 2021
fc23a63
Simplify buffer management
jcrist Nov 5, 2021
d50d9f0
Merge branch 'main' into asyncio-comms
jcrist Nov 23, 2021
682eed8
Cleanups
jcrist Nov 23, 2021
95f44e7
Prioritize IPV4 over IPV6 when reporting addresses
jcrist Nov 24, 2021
3647062
coalesce small buffers
jcrist Dec 3, 2021
e65467e
Fixup memoryview nbytes
jcrist Dec 6, 2021
01d99b4
Add write backpressure, respond to comments
jcrist Dec 6, 2021
cd47373
A few fixups
jcrist Dec 9, 2021
3a8acf5
More fixups
jcrist Dec 9, 2021
8351fbf
mypy fixup
jcrist Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion distributed/comm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,32 @@
unparse_host_port,
)
from .core import Comm, CommClosedError, connect, listen
from .registry import backends
from .utils import get_tcp_server_address, get_tcp_server_addresses


def _register_transports():
from . import inproc, tcp, ws
import dask.config

from . import inproc, ws

tcp_backend = dask.config.get("distributed.comm.tcp.backend")

if tcp_backend == "asyncio":
from . import asyncio_tcp

backends["tcp"] = asyncio_tcp.TCPBackend()
backends["tls"] = asyncio_tcp.TLSBackend()
elif tcp_backend == "tornado":
from . import tcp

backends["tcp"] = tcp.TCPBackend()
backends["tls"] = tcp.TLSBackend()
else:
raise ValueError(
f"Expected `distributed.comm.tcp.backend` to be in `('asyncio', "
f"'tornado')`, got {tcp_backend}"
)

try:
from . import ucx
Expand Down
Loading