Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: change from using SafeConfigParser to ConfigParser #6605

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

tacaswell
Copy link
Contributor

SafeConfigParser has been deprecated since Python 3.2 and will
be removed in py312.

python/cpython#28292
https://bugs.python.org/issue45173
python/cpython#89336

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   7h 18m 26s ⏱️ + 5m 43s
  2 879 tests ±0    2 762 ✔️  - 31    83 💤 ±0  29 +26  5 🔥 +5 
21 332 runs  +2  20 299 ✔️  - 63  962 💤  - 3  63 +60  8 🔥 +8 

For more details on these failures and errors, see this check.

Results for commit 01dc6df. ± Comparison against base commit 96c13a5.

♻️ This comment has been updated with latest results.

SafeConfigParser has been deprecated since Python 3.2 and will
be removed in py312.

python/cpython#28292
https://bugs.python.org/issue45173
python/cpython#89336
@quasiben
Copy link
Member

ok to test

@quasiben
Copy link
Member

Thanks @tacaswell . I see this was also done in python-versioneer/python-versioneer#207 . Merging in

@quasiben
Copy link
Member

As a note, the failures in CI are unrelated to this PR

@quasiben quasiben merged commit 1c48633 into dask:main Jun 23, 2022
@tacaswell tacaswell deleted the fix_py312 branch June 23, 2022 13:51
@tacaswell
Copy link
Contributor Author

I know that versioneer has also fixed this upstream, however I decided to do the minimal fix rather an updating versioneer as I have semi-automated this process and have opened like 200 PRs with this change. It was my judgement that more projects would take the small fix more quickly than a full versioneer upgrade ;)

@tacaswell tacaswell restored the fix_py312 branch November 23, 2023 20:17
@tacaswell tacaswell deleted the fix_py312 branch November 25, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants