Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix test_rechunk_auto_1d #8870

Closed
wants to merge 1 commit into from

Conversation

jrbourbeau
Copy link
Member

Closes #8869 by updating the test to use the new expected output chunks

cc @phofl

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ±0      25 suites  ±0   10h 16m 15s ⏱️ + 5m 41s
 4 125 tests ±0   4 009 ✅ + 3    111 💤 ±0   5 ❌  -  3 
47 651 runs  ±0  45 509 ✅ +11  2 106 💤 +1  36 ❌  - 12 

For more details on these failures, see this check.

Results for commit f8020f8. ± Comparison against base commit b28822b.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is an intentional change in dask/dask this seems fine to me. CI still seems unhappy though.

@jrbourbeau
Copy link
Member Author

Thanks @jacobtomlinson. The change in chunks here is probably related to dask/dask#11383. Still trying to figure out how to best update the logic on the dask/dask side. Worst-case, we revert dask/dask#11354 before the next release

@jrbourbeau jrbourbeau changed the title Fix test_rechunk_auto_1d [WIP] Fix test_rechunk_auto_1d Sep 11, 2024
@jrbourbeau
Copy link
Member Author

Closed via dask/dask#11385

@jrbourbeau jrbourbeau closed this Sep 12, 2024
@jrbourbeau jrbourbeau deleted the test_rechunk_auto_1d-fixup branch September 12, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distributed/shuffle/tests/test_rechunk.py::test_rechunk_auto_1d[20-chunks4-5-expected4] failing on main
2 participants