This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
Prevent "webpacking" of native dependencies #508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During debugging some connection issue on the react branch I found that
utp-native
couldn't be loaded and as a resultutp
wasn't available.utp
is loaded throughnode-gyp-build
whichsload
-method has a wildcard-require, resulting in following warning:This means that as-is webpack can not find the depending packages. This PR marks all node-modules as external, which puts it in a similar build structure as is currently used by the choo-builds and thus allows access to
utp-native
.