This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
Readded info-screen #523
Merged
Readded info-screen #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Making sure that onupdate is not called before the return happened in order to prevent zalgo from hauting us at night. * Fixing problems with not running update in zalgo style. * Making sure that the dats are closed before trying to join the network.
* End the app if an error occurs * Fixing a proper reset of the tests folder * Made tests cancelable through Ctrl+C * Updated tap dependency * Using shebang to make sure the correct executable is called. * Proper tape tests need to be ended. * Making use of resolveMatch for shorter, better readable tests * Using waitForAndClick to get cleaner, quicker tests that don’t fail. * Extracted wait into until * The Default wait period is too long in those cases * Using waitForExist for quicker results. * Used shebang for tests/index * Using tap for all tests. * Using waitForMatch to quicker find out if a match exist and don’t fail the test if the text happens to show something different in-between (like the loading bytes) * shebang error on windows * Better error logs on windows tests * Updated spectron
* contributing: add pull request time frame * add week days
Fixes spacing for interface
martinheidegger
force-pushed
the
add/info
branch
from
39c872e
to
fe9efec
Compare
martinheidegger
force-pushed
the
add/info
branch
from
fe9efec
to
37c1036
Compare
martinheidegger
force-pushed
the
add/info
branch
from
37c1036
to
e14a27d
Compare
aks-
approved these changes
Apr 13, 2018
| @@ -314,6 +318,14 @@ const redatApp = (state = defaultState, action) => { | |||
| } | |||
| } | |||
| } | |||
| case 'TOGGLE_MENU': | |||
There was a problem hiding this comment.
do you think it would make more sense to call it TOGGLE_BUG_MENU instead?
There was a problem hiding this comment.
Right now it only shows the debug information but I believe it was added to hold more information.
There was a problem hiding this comment.
aha i see. looks good, i think we can merge it then
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the react branch the info-screen (hamburger button) of the master branch wasn't added. This PR adds the info-screen with the Report-bug button.