This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
Fix: Update inspection data only in "inspect" screen #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinheidegger
changed the title
martinheidegger
approved these changes
Oct 18, 2018
| @@ -0,0 +1,11 @@ | |||
| export const INTRO = 'intro' | |||
| import Inspect from '../components/inspect' | ||
| import { closeInspectDat } from '../actions' | ||
| import { connect } from 'react-redux' | ||
|
|
||
| const mapStateToProps = state => ({ | ||
| dat: state.dats[state.inspect.key] | ||
| dat: state.screen === SCREEN.INSPECT ? state.dats[state.inspect.key] : null |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that an error with the Inspection screen.
It tried to update the inspected DAT even when navigating to other screens.
https://github.com/dat-land/dat-desktop/pull/562/files#diff-bf58091931fe43a77612c0916614753dL8
This PR now updates the dat only when the inspect screen is selected.
This PR is based on #561