This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
fixed: focussing on title-edit #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed: support for styled-components v4. and linting
martinheidegger
changed the title
martinheidegger
approved these changes
Nov 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title that were editable need to be clicked before the user can edit text.
This problem seems to have been caused by the update to styled-components v4
But even after a save: the title isn't stored because of https://github.com/dat-land/dat-desktop/pull/602/files#diff-84f92d50bee815f7173b3515a7313e7fL63
This PR fixes the behavior: Now the users can immediately change the title: