Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for dat-store, fixed up extensions #1091

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Added support for dat-store, fixed up extensions #1091

merged 2 commits into from
Apr 2, 2019

Conversation

RangerMauve
Copy link
Contributor

  • Fixes extensions not being able to show help messages
  • Fixes launching extensions on Windows (it needed to be spawned as .cmd)
  • Adds support for the dat-store extension

@RangerMauve RangerMauve requested a review from joehand April 2, 2019 19:04
joehand
joehand reviewed Apr 2, 2019
View reviewed changes
bin/cli.js Show resolved Hide resolved
joehand
joehand approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@joehand joehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RangerMauve
Copy link
Contributor Author

Does this look good to merge? I'd like to add it to the draft of my Dat blog post.

@joehand
Copy link
Collaborator

joehand commented Apr 2, 2019

Yep!

@RangerMauve RangerMauve merged commit e974fd7 into master Apr 2, 2019
@RangerMauve
Copy link
Contributor Author

Would you mind publishing the release? I don't have 2FA enabled on NPM.

@joehand joehand deleted the store branch June 19, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehand joehand joehand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RangerMauve @joehand