Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper keyword from eigh and eigvalsh. #226

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Conversation

lezcano
Copy link
Contributor

@lezcano lezcano commented Jul 14, 2021

As per the title

Fixes #217

cc @rgommers @asmeurer @kgryte

Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made minor edits to ensure positional-only arguments.

spec/extensions/linear_algebra_functions.md Outdated Show resolved Hide resolved
spec/extensions/linear_algebra_functions.md Outdated Show resolved Hide resolved
@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Linear Algebra Linear algebra. labels Jul 26, 2021
@kgryte
Copy link
Contributor

kgryte commented Aug 23, 2021

This PR can be merged once gh-243 is merged, which adds tril and triu to the specification.

@kgryte
Copy link
Contributor

kgryte commented Sep 20, 2021

gh-243 has now been merged. Merging...

@kgryte kgryte merged commit b0b23be into data-apis:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API. topic: Linear Algebra Linear algebra.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Remove upper argument from eigh and eigvalsh
2 participants