Clarify expected behavior when providing a complex number array to all and any
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
API change
|
Do |
|
@asmeurer Yes, they already support all supported data types; see array-api/spec/API_specification/array_api/utility_functions.py Lines 15 to 16 in 34aa925 This PR adds clarification, similar to floating-point infinities and NaN, for how complex numbers should evaluate to |
|
As this PR has received approval and the changes are straightforward, will go ahead and merge. Any further changes can be addressed in subsequent PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
allandany. Namely, complex number values having a non-zero component (real or imaginary) must evaluate toTrue.