Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add complex number support to positive #447

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Add complex number support to positive #447

merged 1 commit into from
Jun 6, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented May 30, 2022

This PR

  • adds complex number support to positive (and __pos__). No special considerations need to be made for complex numbers, as positive is effectively an identity function.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels May 30, 2022
@kgryte kgryte added this to the v2022 milestone May 30, 2022
@kgryte kgryte mentioned this pull request May 30, 2022
Closed
@kgryte
Copy link
Contributor Author

kgryte commented Jun 6, 2022

Thanks, @leofang! Will merge, as the changes are straightforward and align with existing array implementations.

@kgryte kgryte merged commit 3049999 into main Jun 6, 2022
@kgryte kgryte deleted the cmplx-positive branch June 6, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @leofang