Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying the output array dtype in linalg.trace #502

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Add support for specifying the output array dtype in linalg.trace #502

merged 4 commits into from
Nov 14, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 3, 2022

This PR

@kgryte kgryte added API extension Adds new functions or objects to the API. API change Changes to existing functions or objects in the API. topic: Linear Algebra Linear algebra. labels Nov 3, 2022
@kgryte kgryte added this to the v2022 milestone Nov 3, 2022
@kgryte
Copy link
Contributor Author

kgryte commented Nov 3, 2022

Based on the 3 November 2022 meeting, no objections were raised to the changes introduced in this PR. Will keep open for another week to allow further comment.

@kgryte
Copy link
Contributor Author

kgryte commented Nov 14, 2022

As the changes introduced in this PR follow the same guidance as sum, will merge. Any further modifications can be performed in follow-up PRs.

@kgryte kgryte merged commit 2024bd1 into main Nov 14, 2022
@kgryte kgryte deleted the trace-promotion-rules branch November 14, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. API extension Adds new functions or objects to the API. topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.

Use similar promotion rules in trace() as sum() and prod()
1 participant
@kgryte