Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake in description of return dtype for matrix_rank #510

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

rgommers
Copy link
Member

This was a simple mistake, not discussed in the review for the PR that added matrix_rank (gh-128).

Closes gh-469

This was a simple mistake, not discussed in the review for the PR
that added `matrix_rank` (data-apisgh-128).

Closes data-apisgh-469
@rgommers rgommers added Maintenance Bug fix, typo fix, or general maintenance. topic: Linear Algebra Linear algebra. labels Nov 16, 2022
@rgommers rgommers requested a review from kgryte November 16, 2022 22:26
@rgommers rgommers added this to the v2022 milestone Nov 16, 2022
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing!

@kgryte kgryte merged commit 6d88b3f into data-apis:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance. topic: Linear Algebra Linear algebra.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regarding return type of matrix_rank in Linear_Algebra module
2 participants