Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex number support to vecdot #512

Merged
merged 10 commits into from
Dec 14, 2022
Merged

Conversation

rgommers
Copy link
Member

Closes gh-356 (where the definition x1^H x2 was decided).

Closes data-apisgh-356 (where the definition x1^H x2 was decided).
@rgommers rgommers added the topic: Complex Data Types Complex number data types. label Nov 17, 2022
@rgommers rgommers added this to the v2022 milestone Nov 17, 2022
@rgommers rgommers requested a review from kgryte November 17, 2022 11:45
@kgryte
Copy link
Contributor

kgryte commented Dec 14, 2022

I'll review and update this PR shortly.

@kgryte
Copy link
Contributor

kgryte commented Dec 14, 2022

Updated to reflect extended description conventions used for other linalg APIs. The description is functionality equivalent to expressing the vector product as a matrix product of two column vectors involving a conjugate transpose and is thus aligned with gh-356.

As consensus was previously established to define the complex dot product in terms of the conjugate transpose, will merge. Thanks, @rgommers!

@kgryte kgryte merged commit 7eee20d into data-apis:main Dec 14, 2022
@rgommers rgommers deleted the vecdot-complex branch December 14, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: Complex Data Types Complex number data types.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition of vecdot is ambiguous in the complex case.
3 participants