Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for complex number addition #525

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Add support for complex number addition #525

merged 2 commits into from
Dec 13, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 27, 2022

This PR

  • adds support for complex number addition. Complex number addition is well-defined, where (a + bj) + (c + dj) = (a+c) + (c+d)j.
  • Specifies that the special cases described for real-valued floating-point operands apply to the component operations separately. Meaning, operations involving real-valued components (i.e., a, b, c, d) must abide by real-valued floating-point special cases.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Nov 27, 2022
@kgryte kgryte added this to the v2022 milestone Nov 27, 2022
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @kgryte

@rgommers rgommers merged commit 8062655 into main Dec 13, 2022
@rgommers rgommers deleted the cmplx-add branch December 13, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants