Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add complex number support to linalg.cross #559

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Add complex number support to linalg.cross #559

merged 1 commit into from
Dec 14, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Dec 12, 2022

This PR

  • adds complex number support to linalg.cross. No special considerations are required to accommodate complex numbers.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.
  • updates guidance to require a numeric data type. Previously, it said "should", but this was likely an oversight, as computing the cross product for non-numeric data types does not make sense.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 12, 2022
@kgryte kgryte added this to the v2022 milestone Dec 12, 2022
@kgryte kgryte mentioned this pull request Dec 12, 2022
Closed
rgommers
rgommers approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommers rgommers merged commit e9a1683 into main Dec 14, 2022
@rgommers rgommers deleted the cmplx-cross branch December 14, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @rgommers