Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a page on exceptions, and treat exceptions more consistently #613

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Add a page on exceptions, and treat exceptions more consistently #613

merged 2 commits into from
Apr 17, 2023

Conversation

rgommers
Copy link
Member

Closes gh-606

@rgommers rgommers added the Narrative Content Narrative documentation content. label Mar 21, 2023
@rgommers rgommers mentioned this pull request Mar 21, 2023
Closed
@leofang leofang self-requested a review March 23, 2023 18:37
@leofang
Copy link
Contributor

leofang commented Mar 31, 2023

Thanks, Ralf! The exception page LGTM. Didn't check the code carefully due to small screen, though.

kgryte
kgryte approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte
Copy link
Contributor

kgryte commented Apr 17, 2023

This has now been open for a few weeks. Will go ahead and merge. If further edits are necessary, these can be addressed in follow-up PRs.

@kgryte kgryte added this to the v2023 milestone Apr 17, 2023
@kgryte kgryte merged commit 891d89d into data-apis:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@leofang leofang Awaiting requested review from leofang

Assignees
No one assigned
Labels
Narrative Content Narrative documentation content.
Projects
None yet
Milestone
v2023
Development

Successfully merging this pull request may close these issues.

Would it make sense to add ShapeError and BroadcastingError
3 participants
@rgommers @leofang @kgryte