Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix svd function return dtype #619

Merged
merged 3 commits into from
May 2, 2023
Merged

Fix svd function return dtype #619

merged 3 commits into from
May 2, 2023

Conversation

steff456
Copy link
Member

This PR,

  • Fixes the return dtype of svd in the draft version of the spec
  • Fixes the return dtype of svd in the 2022.12 version of the spec

@steff456 steff456 added bug Something isn't working. topic: Linear Algebra Linear algebra. labels Apr 13, 2023
@steff456 steff456 self-assigned this Apr 13, 2023
rgommers
rgommers reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456. This looks like it fixes an oversight, and looks like an improvement. We can do even better though - the return value is always a length-3 tuple, so I think this is more precise:

Tuple[array, array, array]

@kgryte
Copy link
Contributor

kgryte commented Apr 17, 2023

@steff456 This fix also needs to be backported to the 2021 revision.

@kgryte kgryte added the Backport Changes involve backporting to previous versions. label Apr 17, 2023
rgommers
rgommers approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, in it goes. Thanks @steff456

@rgommers rgommers merged commit accf8c2 into data-apis:main May 2, 2023
@kgryte kgryte deleted the fix-signatures branch February 25, 2024 05:46
@kgryte kgryte added this to the v2023 milestone Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

@rgommers rgommers rgommers approved these changes

Assignees

@steff456 steff456

Labels
Backport Changes involve backporting to previous versions. bug Something isn't working. topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2023
Development

Successfully merging this pull request may close these issues.
3 participants
@steff456 @kgryte @rgommers