Add specification for moving array axes to new positions #656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
moveaxis
&swapaxes
#483 by adding a specification formoveaxis
.moveaxis
in its main namespace, but it does include it in its experimental NumPy namespace.Questions
permute_dims
andexpand_dims
. Should we be consistent here in renamingmoveaxis
to, e.g.,move_dims
? PyTorch predominantly uses thedims
convention and aliasesmoveaxis
asmovedim
, which is not a perfect match given the missing_
and plural formdims
.moveaxis
given widespread array library usage ofmoveaxis
. Renaming to something consistent withpermute_dims
andexpand_dims
would likely cause unnecessary churn for insufficient benefit.