Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use parameter name obj in asarray device doc #681

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Use parameter name obj in asarray device doc #681

merged 1 commit into from
Sep 7, 2023

Conversation

aaronmondal
Copy link
Contributor

The asarray creation function uses obj instead of x.

@aaronmondal
Use parameter name obj in asarray device doc
713ac91 
The asarray creation function uses obj instead of x.
honno
honno approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

rgommers
rgommers approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks @aaronmondal

@rgommers rgommers merged commit caf1011 into data-apis:main Sep 7, 2023
2 checks passed
@rgommers rgommers added the Maintenance Bug fix, typo fix, or general maintenance. label Sep 7, 2023
@kgryte kgryte added this to the v2023 milestone Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@honno honno honno approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
v2023
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronmondal @rgommers @honno @kgryte