Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wording for comparison operators. #736

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Fix wording for comparison operators. #736

merged 5 commits into from
Jan 25, 2024

Conversation

hameerabbasi
Copy link
Contributor

@hameerabbasi hameerabbasi commented Jan 23, 2024 •
edited
Loading

Fixes #737

@asmeurer
Copy link
Member

Yes, this was a mistake. Maybe we should include the same text as in the functional version

array-api/src/array_api_stubs/_2022_12/elementwise_functions.py

Line 1376 in 293512d

For backward compatibility, conforming implementations may support complex numbers; however, inequality comparison of complex numbers is unspecified and thus implementation-dependent (see :ref:`complex-number-ordering`).

@leofang leofang added this to the v2023 milestone Jan 23, 2024
@kgryte
Copy link
Contributor

kgryte commented Jan 25, 2024

@hameerabbasi Looks like there may be some trailing whitespace which needs to be removed to make CI happy.

@kgryte kgryte added Backport Changes involve backporting to previous versions. topic: Complex Data Types Complex number data types. labels Jan 25, 2024
kgryte
kgryte approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Hameer!

@kgryte kgryte merged commit 95332bb into data-apis:main Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Backport Changes involve backporting to previous versions. topic: Complex Data Types Complex number data types.
Projects
None yet
Milestone
v2023
Development

Successfully merging this pull request may close these issues.

Wording for comparison operators implies complex number support for inequality operators
4 participants
@hameerabbasi @asmeurer @kgryte @leofang