Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify shape of values and order of counts in unique APIs #752

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Feb 22, 2024

This PR

@kgryte kgryte added the Narrative Content Narrative documentation content. label Feb 22, 2024
@kgryte kgryte added this to the v2023 milestone Feb 22, 2024
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified that this matches the actual behavior of NumPy, and aligns with previous comments on this topic.

@rgommers rgommers merged commit 11273e6 into data-apis:main Feb 22, 2024
3 checks passed
@kgryte kgryte deleted the fix/unique-flattening branch February 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Narrative Content Narrative documentation content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unique_all doesn't specify that indices should be a flattened index
2 participants