-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python 3.10 PR #48
Fix Python 3.10 PR #48
Conversation
simonbohnen
commented
Sep 26, 2022
•
edited
Loading
edited
- add boto3
- provide credentials for minio via environment variables
- set endpoint URL correctly in code
- fix fake-gcs-server to not send checksums for partial requests (HTTP status 206) and use that version for CI
- pin setuptools-scm to 6.4.2 to be compatible with Python 3.6
- @xhochy should we drop Python 3.6 support instead?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## python-3.10 #48 +/- ##
=============================================
Coverage ? 0.00%
=============================================
Files ? 28
Lines ? 1771
Branches ? 0
=============================================
Hits ? 0
Misses ? 1771
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We should drop 3.6, we can also drop 3.7 and only support 3.8+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
The pre-commit hooks seem to fail due to the merge from a fork. They pass here. |
Can you remove minimalkv/.github/workflows/ci.yml Line 56 in f2012e7
|
@xhochy Thank you, that's probably the source 👌🏼 |
Looks good except the comments that were already raised by @janjagusch. |
@xhochy, all my comments have been resolved, so I think this is good to get merged. Also, should we merge straight into |
Yes! |
Thx for changing that 👌🏼 Can you merge the PR? |