Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.10 PR #48

Merged
merged 27 commits into from
Oct 5, 2022
Merged

Conversation

simonbohnen
Copy link
Contributor

@simonbohnen simonbohnen commented Sep 26, 2022

  • add boto3
    • provide credentials for minio via environment variables
    • set endpoint URL correctly in code
  • fix fake-gcs-server to not send checksums for partial requests (HTTP status 206) and use that version for CI
  • pin setuptools-scm to 6.4.2 to be compatible with Python 3.6
    • @xhochy should we drop Python 3.6 support instead?

@simonbohnen simonbohnen changed the title Add boto3 to environment.yml Fix Python 3.10 PR Sep 30, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (python-3.10@c5b3f45). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             python-3.10     #48   +/-   ##
=============================================
  Coverage               ?   0.00%           
=============================================
  Files                  ?      28           
  Lines                  ?    1771           
  Branches               ?       0           
=============================================
  Hits                   ?       0           
  Misses                 ?    1771           
  Partials               ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simonbohnen simonbohnen marked this pull request as ready for review October 4, 2022 09:40
@xhochy
Copy link
Member

xhochy commented Oct 4, 2022

We should drop 3.6, we can also drop 3.7 and only support 3.8+

Copy link
Contributor

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
environment.yml Show resolved Hide resolved
tests/bucket_manager.py Outdated Show resolved Hide resolved
tests/test_boto3_store.py Show resolved Hide resolved
@simonbohnen simonbohnen requested review from janjagusch and removed request for xhochy, fjetter, siboehm and mlondschien October 4, 2022 12:17
@simonbohnen
Copy link
Contributor Author

The pre-commit hooks seem to fail due to the merge from a fork. They pass here.

@xhochy
Copy link
Member

xhochy commented Oct 4, 2022

Can you remove

ref: ${{ github.head_ref }}
and see whether that fixes the pre-commit?

@simonbohnen
Copy link
Contributor Author

Can you remove

ref: ${{ github.head_ref }}

and see whether that fixes the pre-commit?

@xhochy Thank you, that's probably the source 👌🏼

@xhochy
Copy link
Member

xhochy commented Oct 4, 2022

Looks good except the comments that were already raised by @janjagusch.

@janjagusch
Copy link
Contributor

janjagusch commented Oct 5, 2022

Looks good except the comments that were already raised by @janjagusch.

@xhochy, all my comments have been resolved, so I think this is good to get merged.

Also, should we merge straight into main, instead of into the python-3.10 branch?

@xhochy xhochy changed the base branch from python-3.10 to main October 5, 2022 07:28
@xhochy
Copy link
Member

xhochy commented Oct 5, 2022

Also, should we merge straight into main, instead of into the python-3.10 branch?

Yes!

@simonbohnen
Copy link
Contributor Author

Also, should we merge straight into main, instead of into the python-3.10 branch?

Yes!

Thx for changing that 👌🏼 Can you merge the PR?

@xhochy xhochy merged commit bcc4fff into data-engineering-collective:main Oct 5, 2022
@simonbohnen simonbohnen deleted the add-boto3 branch October 5, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants