Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(pisa-proxy, sharding): add database_table sharding rewrite #380

Merged
merged 16 commits into from
Nov 21, 2022

Conversation

xuanyuan300
Copy link
Contributor

What is changed and how it works?

What's Changed:

  1. Add sharding rewrite for database_table sharding strategy.

This PR fix some issue also.

  1. Fix return incorrect result when execute sql that include count function. Close Count function merge failed #378
  2. Fix rewrite sql incorrect when execute insert statements in database sharding strategy.
  3. Fix return incorrect result when execute sql that include avg,min,max aggregation function.

@xuanyuan300 xuanyuan300 added the app:pisa-proxy Pisa-Proxy related changes label Nov 21, 2022
@xuanyuan300 xuanyuan300 added this to the v0.3.2 milestone Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #380 (4ec5dd3) into master (df61eb4) will increase coverage by 7.70%.
The diff coverage is 84.76%.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   66.97%   74.68%   +7.70%     
==========================================
  Files           7        6       -1     
  Lines         427      719     +292     
==========================================
+ Hits          286      537     +251     
- Misses        133      171      +38     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 74.68% <84.76%> (+7.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) ⬇️
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 51.35% <44.11%> (-6.55%) ⬇️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 94.13% <98.33%> (+2.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pisa-proxy/protocol/mysql/src/row.rs Show resolved Hide resolved
@wbtlb wbtlb merged commit 1de659f into database-mesh:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-proxy Pisa-Proxy related changes size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count function merge failed
2 participants