refactor: SessionContext doesn't require Arc
#15491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
changed the title
SessionContext doesn't require ArcSessionContext doesn't require Arc
github-actions
bot
added
the
pr-refactor
BohuTANG
approved these changes
May 12, 2024
Embrace idiomatic Rust practices by reducing unnecessary sharing. In this case, since `SessionContext` is not shared among threads, there is no need to wrap it in an `Arc`. This change streamlines the code and enhances performance by eliminating unneeded atomic reference counting.
This was referenced Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Refactor:
SessionContextdoesn't requireArcEmbrace idiomatic Rust practices by reducing unnecessary sharing. In
this case, since
SessionContextis not shared among threads, there isno need to wrap it in an
Arc. This change streamlines the code andenhances performance by eliminating unneeded atomic reference counting.
Tests
Type of change
Related Issues
This change is