Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): RoleInfo from_pb should not err #15496

Merged
merged 2 commits into from
May 13, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented May 13, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

RoleInfo from_pb should not err

If a new object is added, and the role created in the new databend-query version has only the new object-related permissions. The older version does not recognize the new object and returns err. Cause authentication fails.

e.g.

create role new_role;
grant privilege on new_object to role new_role;

In old query version, will cause auth faild. Because api get_roles will err in from_pb

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label May 13, 2024
@TCeason
Copy link
Collaborator Author

TCeason commented May 13, 2024

cc @flaneur2020 @BohuTANG I think we can merge this pr to main branch.

@BohuTANG BohuTANG merged commit 1a469e5 into databendlabs:main May 13, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants