feat(query): bump arrow-udf version to enhance types supported by JS UDFs #15529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UDFs I made some enhancements to the arrow-udf-js code to improve Databend support. JS UDFs now support Variant, Timestamp, Date and Decimal types in arguments and return values. This version also enables all intrinsics in rquickjs for better JS compatibility.
github-actions
bot
added
the
pr-feature
sundy-li
approved these changes
May 15, 2024
sundy-li
reviewed
May 15, 2024
| @@ -224,8 +224,8 @@ parquet = { version = "51", features = ["async"] } | |||
| parquet_rs = { package = "parquet", version = "51" } | |||
|
|
|||
| # Crates from risingwavelabs | |||
| arrow-udf-js = { package = "arrow-udf-js", git = "https://github.com/datafuse-extras/arrow-udf", rev = "a8fdfdd" } | |||
| arrow-udf-wasm = { package = "arrow-udf-wasm", git = "https://github.com/datafuse-extras/arrow-udf", rev = "a8fdfdd" } | |||
| arrow-udf-js = { package = "arrow-udf-js", git = "https://github.com/datafuse-extras/arrow-udf", rev = "d0a21f0" } | |||
There was a problem hiding this comment.
Maybe we can use the upstream commit now.
b41sh
approved these changes
May 15, 2024
|
Unit failed: https://github.com/datafuselabs/databend/actions/runs/9088408924/job/24977918495?pr=15529 |
|
Ah whoops @BohuTANG - my eyes somehow glossed over the fact that you all use a fork of the main arrow UDF repo. I was using a local crate override while developing this so I didn't notice. It looks like your fork was recently updated to include my changes at that SHA so I suspect that this CI pipeline will pass if you just retry it. I tried to myself just now, but I don't think I have permissions. |
|
At least one type of change must be checked in the PR description. |
|
ok @BohuTANG looks like it's all green now! |
This was referenced Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some enhancements to the arrow-udf-js code to improve Databend support.
JS UDFs now support Variant, Timestamp, Date and Decimal types in arguments and return values.
This update also enables all intrinsics in rquickjs for better JS compatibility.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Tests
Type of change
This change is