refactor: Improve logging and snapshot management #15571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
81-sm-entry
branch
2 times, most recently
from
2b38dca
to
42e4b39
Compare
This commit introduces several enhancements to the snapshot management
system:
- Improved Progress Logging for Snapshot Building
- **Introduction of `SMEntry`:**
- A new structure, `SMEntry`, has been introduced to represent all
variants of a state-machine record. `RaftStoreEntry` is a supper
set of `SMEntry` that includes both state machine record and log
records.
3. **Asynchronous Snapshot Writing:**
- Added the `spawn_writer_thread()` function to facilitate the
writing of snapshots in a separate thread, thereby improving the
performance.
This was referenced Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: Improve logging and snapshot management
This commit introduces several enhancements to the snapshot management
system:
Improved Progress Logging for Snapshot Building
Introduction of
SMEntry:SMEntry, has been introduced to represent allvariants of a state-machine record.
RaftStoreEntryis a supperset of
SMEntrythat includes both state machine record and logrecords.
spawn_writer_thread()function to facilitate thewriting of snapshots in a separate thread, thereby improving the
performance.
Tests
Type of change
Related Issues
This change is