-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): add process collector #15591
Merged
BohuTANG
merged 8 commits into
databendlabs:main
from
flaneur2020:add-process-collector
May 31, 2024
Merged
feat(metrics): add process collector #15591
BohuTANG
merged 8 commits into
databendlabs:main
from
flaneur2020:add-process-collector
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
May 20, 2024
flaneur2020
force-pushed
the
add-process-collector
branch
from
May 20, 2024 12:22
8eb7695
to
e439fd0
Compare
flaneur2020
force-pushed
the
add-process-collector
branch
2 times, most recently
from
May 21, 2024 06:53
bf15244
to
e075981
Compare
Perhaps it can be add process level metrics when reading system.metrics. |
we need find a way to let system.metrics able to expose the metrics from |
zhang2014
approved these changes
May 31, 2024
This was referenced Jul 14, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
fixes #15538
this PR adds the following process metrics, they're considered as the standard process metrics:
as
prometheus/rust-client
still has not builtin support for process collector, this PR adds a vanilla implementation which only works in linux. we can switch to the builtin implementation after prometheus/client_rust#29 got resolved.Tests
Type of change
This change is