Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): decrease information_schema.tables call union #16246

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Aug 14, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. system.tables add a new column table_type If table engine is FUSE, value is BASE TABLE else value is VIEW
  2. system.tables store view name, decrease information_schema.tables call union;

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Do not affect existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

1. system.tables add a new column `table_type` If table engine is FUSE, value is `BASE TABLE` else value is `VIEW`
2. system.tables store view name, decrease information_schema.tables call union;
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 14, 2024
@TCeason
Copy link
Collaborator Author

TCeason commented Aug 14, 2024

cc @hantmac information_schema.tables and system.tables will store view name, but not store view_query.

and system.tables add a new column table_type

@sundy-li sundy-li added this pull request to the merge queue Aug 16, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Aug 16, 2024
@BohuTANG BohuTANG merged commit 486d91e into databendlabs:main Aug 16, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants