Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): make delta table support partition prunning #16621

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Oct 16, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. make delta table support partition prunning
  2. simplify hive table, remove parquet2 codes in hive table
  3. fix ut bug

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

closes #16624


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 16, 2024
@sundy-li sundy-li marked this pull request as ready for review October 16, 2024 10:16
@Xuanwo
Copy link
Member

Xuanwo commented Oct 16, 2024

Can we share the same thing in iceberg later?

@sundy-li
Copy link
Member Author

sundy-li commented Oct 16, 2024

Can we share the same thing in iceberg later?

Yes, maybe next pr. We already have PartitionPruner in common crate now.

@Xuanwo
Copy link
Member

Xuanwo commented Oct 16, 2024

That's great!

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, most change looks good to me.

src/query/storages/delta/src/table.rs Outdated Show resolved Hide resolved
@sundy-li sundy-li changed the title refactor: make delta table support partition prunning refactor(query): make delta table support partition prunning Oct 17, 2024
@BohuTANG BohuTANG merged commit efa1e96 into databendlabs:main Oct 17, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: diff unit test cases fail with same reason entity not found (No such file or directory (os error 2)).
6 participants