Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): check_timestamp/date -> clamp_timestamp/date #16634

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Oct 17, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

If Date/Timestamp is invalide, convert it to Date/TimestampMIN

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 17, 2024
@TCeason TCeason force-pushed the modify_check_ts branch 2 times, most recently from fb9f1bb to 1e35988 Compare October 17, 2024 10:51
If Date/Timestamp is invalide, convert it to Date/TimestampMIN
@sundy-li
Copy link
Member

docs need to be updated. cc @soyeric128

@BohuTANG BohuTANG merged commit 7a6f1fb into databendlabs:main Oct 21, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants