Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): Settings clause #16669

Merged
merged 6 commits into from
Oct 30, 2024
Merged

feat(query): Settings clause #16669

merged 6 commits into from
Oct 30, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Oct 23, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Settings clause

Syntax

settings (setting_name=value, ...) stmt

More info: #16387

Fixes: #16387

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 23, 2024
@TCeason TCeason force-pushed the setting branch 2 times, most recently from c10635f to 7a7b577 Compare October 23, 2024 10:04
@TCeason TCeason force-pushed the setting branch 3 times, most recently from ce965e2 to f9b4699 Compare October 28, 2024 10:59
@TCeason
Copy link
Collaborator Author

TCeason commented Oct 28, 2024

cc @soyeric128 Doc needed. Settings is better than set_var hints. So we prefer to use settings.

sundy-li
sundy-li approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@sundy-li sundy-li added this pull request to the merge queue Oct 30, 2024
Merged via the queue into databendlabs:main with commit ee8fb25 Oct 30, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Settings clause
2 participants
@TCeason @sundy-li