Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): add table function udf_echo && expose more metrics of udf client #16696

Merged
merged 12 commits into from
Oct 29, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Oct 28, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat: add udf_echo table function && expose more metrics of udf client

after databendlabs/databend-udf#11

  1. udf_echo table function

example:

select * from udf_echo('http://m1:8815', 'abc');
┌────────┐
│ result │
│ String │
├────────┤
│ abc    │
└────────┘
  1. add more metrics of udf client, now udf client has metrics as below.
| external_requests_total                 | counter   | {"function_name":"wait"}  |
│ external_running_requests_total  │ counter   │ {"function_name":"wait"}  |

│ external_connect_duration_sum     │ untyped    │ {"function_name":"wait"}  |
│ external_connect_duration_count   │ untyped    │ {"function_name":"wait"}  |
│ external_connect_duration_bucket │ histogram │ {"function_name":"wait"}  |

│ external_request_duration_sum    │ untyped   │ {"function_name":"wait"}  |
│ external_request_duration_count  │ untyped   │ {"function_name":"wait"}  |
│ external_request_duration_bucket │ histogram │ {"function_name":"wait"}  |

│ external_retry_total             │ counter   │ {"function_name":"wait","error_kind":"ConnectError"} │
│ external_error_total             │ counter   │ {"function_name":"wait","error_kind":"ConnectError"} │

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li changed the title feat: add scalar function telnet && expose more metrics of udf client feat(query): add scalar function telnet && expose more metrics of udf client Oct 28, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 28, 2024
@sundy-li sundy-li changed the title feat(query): add scalar function telnet && expose more metrics of udf client feat(query): add table function udf_echo && expose more metrics of udf client Oct 28, 2024
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sundy-li sundy-li added this pull request to the merge queue Oct 29, 2024
Merged via the queue into databendlabs:main with commit 6a4588c Oct 29, 2024
72 checks passed
@sundy-li sundy-li deleted the udf-metric branch October 29, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants