refactor: Consolidate MetaStorageError variants
#16760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
Replace multiple error variants with a single `Damaged` variant: - Remove: BytesError, SnapshotError, SledError - Add: Damaged These errors share the same error handling logic, making a single variant more maintainable and semantically clearer.
drmingdrmer
force-pushed
the
162-cleanup-error
branch
from
841b4ae
to
93a9a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: Consolidate
MetaStorageErrorvariantsReplace multiple error variants with a single
Damagedvariant:These errors share the same error handling logic, making a single
variant more maintainable and semantically clearer.
Tests
Type of change
Related Issues
This change is