Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up feature-specific lint warnings #1256

Closed
drmingdrmer opened this issue Oct 14, 2024 · 1 comment · Fixed by #1257
Closed

clean up feature-specific lint warnings #1256

drmingdrmer opened this issue Oct 14, 2024 · 1 comment · Fixed by #1257

Comments

@drmingdrmer
Copy link
Member

There are multiple "unused" warnings reported by GitHub Actions on the review page, are they false-positive? If not, perhaps we can do a clean-up:)

Such as:
https://github.com/databendlabs/openraft/pull/1255/files

Originally posted by @SteveLauC in #1255 (review)
@github-actions GitHub Actions
Copy link

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

@drmingdrmer drmingdrmer mentioned this issue Oct 14, 2024
Merged
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Oct 14, 2024
@drmingdrmer
Chore: fix feature specific lint warnings
8dffed0 
- Fix: databendlabs#1256
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue Oct 15, 2024
@drmingdrmer
Chore: fix feature specific lint warnings
b2898b8 
- move `use` to inside feature gated test function
- use PanicHookInfo instead of deprecated PanicInfo

- Fix: databendlabs#1256
getong pushed a commit to getong/openraft that referenced this issue Oct 15, 2024
@drmingdrmer
Chore: fix feature specific lint warnings
e4330a1 
- move `use` to inside feature gated test function
- use PanicHookInfo instead of deprecated PanicInfo

- Fix: databendlabs#1256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: fix feature specific lint warnings drmingdrmer/openraft
1 participant
@drmingdrmer