Refactor: introducing CommittedVote, NonCommittedVote, and RefVote types #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- **Introduce Specialized Vote Types:**
- Added `CommittedVote` and `NonCommittedVote` to distinguish between votes that have been
accepted by a quorum and those that have not.
- Introduced `RefVote` to provide a reference-based representation of votes, facilitating safer
and more efficient comparisons.
- **Update Vote Management Logic:**
- Replaced direct usage of `Vote` with `CommittedVote` and `NonCommittedVote` across various
modules (`heartbeat/worker.rs`, `notification.rs`, `raft_core.rs`, etc.) to enhance type
safety and clarity.
- Modified comparison logic to leverage the new vote types, ensuring accurate and meaningful
ordering based on vote status.
- **Enhance Notification Mechanisms:**
- Updated notification structures to use the new vote types, improving the accuracy of messages
related to vote responses and higher votes observed.
drmingdrmer
force-pushed
the
157-use-committed-and-non-committed-vote
branch
from
6c91be7
to
39a77dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Refactor: introducing CommittedVote, NonCommittedVote, and RefVote types
Introduce Specialized Vote Types:
CommittedVoteandNonCommittedVoteto distinguish between votes that have beenaccepted by a quorum and those that have not.
RefVoteto provide a reference-based representation of votes, facilitating saferand more efficient comparisons.
Update Vote Management Logic:
VotewithCommittedVoteandNonCommittedVoteacross variousmodules (
heartbeat/worker.rs,notification.rs,raft_core.rs, etc.) to enhance typesafety and clarity.
ordering based on vote status.
Enhance Notification Mechanisms:
related to vote responses and higher votes observed.
This change is